commit c7702c47bb887a220233fd92d80a1084a25f2a27
parent e91cabb704b1cfc1cae438f5be8600e83dc5578e
Author: Daenney <daenney@users.noreply.github.com>
Date: Tue, 16 May 2023 15:09:29 +0200
[chore] Change time comparison in webfinger test (#1798)
Every now and then the TestFingerWithHostMetaCacheStrategy would fail on
a time related error. I suspect suite.Equal doesn't quite work as
expected when given two time.Time's, so instead explicitly check with
the time.Equal.
Diffstat:
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/internal/transport/finger_test.go b/internal/transport/finger_test.go
@@ -87,9 +87,12 @@ func (suite *FingerTestSuite) TestFingerWithHostMetaCacheStrategy() {
// the TTL of the entry should have extended because we did a second
// successful finger
- suite.NotEqual(initialTime, repeatTime, "expected webfinger cache entry to have different expiry times")
+ if repeatTime.Equal(initialTime) {
+ suite.FailNowf("expected webfinger cache entry to have different expiry times", "initial: '%s', repeat: '%s'", initialTime, repeatTime)
+ }
+
if repeatTime.Before(initialTime) {
- suite.FailNow("expected webfinger cache entry to not be a time traveller")
+ suite.FailNowf("expected webfinger cache entry to not be a time traveller", "initial: '%s', repeat: '%s'", initialTime, repeatTime)
}
// finger a non-existing user on that same instance which will return an error
