gtsocial-umbx

commit 8e80f983b354f90a4a8b701383ce682c9163b59b
parent 9cf66bf29871dad6523f421ae72125d584ac4c9a
Author: Terin Stock <terinjokes@gmail.com>
Date:   Thu, 28 Apr 2022 00:43:41 -0700

[bugfix] use Exec to rename media_attachments (#498)

The `database/sql` package in the Go stdlib has two methods that can run
queries against the database driver: `Query` and `Exec`. When the query
returns rows, such as "SELECT", the package expects the use of `Query`,
and returns `*sql.Rows`. When the query does not return rows, the
package expects the use of `Exec`, which returns `sql.Result`.

This changeset corrects the "media_attachments" migration to using
`ExecContext`, as "ALTER TABLE" does not return rows.

Signed-off-by: Terin Stock <terinjokes@gmail.com>
Diffstat:
M
internal/db/bundb/migrations/20220214175650_media_cleanup.go
 | 
2
+-

1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/internal/db/bundb/migrations/20220214175650_media_cleanup.go b/internal/db/bundb/migrations/20220214175650_media_cleanup.go
@@ -142,7 +142,7 @@ func init() {
 			}
 
 			// rename the new table to the same name as the old table was
-			if _, err := tx.QueryContext(ctx, "ALTER TABLE new_media_attachments RENAME TO media_attachments;"); err != nil {
+			if _, err := tx.ExecContext(ctx, "ALTER TABLE new_media_attachments RENAME TO media_attachments;"); err != nil {
 				return err
 			}