gtsocial-umbx

commit 827cc4df56de0c4c201246c5c427ecda1bc73448
parent 24fbdf2b0a820684b69b10893e82cdb1a76ca14d
Author: tobi <31960611+tsmethurst@users.noreply.github.com>
Date:   Wed, 14 Jun 2023 15:08:31 +0200

[chore/bugfix] Demote failed inbox forwarding to warn log rather than error return (#1892)


Diffstat:
M
internal/federation/federatingactor.go
 | 
5
+++--

1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/internal/federation/federatingactor.go b/internal/federation/federatingactor.go
@@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr
 		// is updated, and/or federating callbacks are handled
 		// properly.
 		if !errors.Is(err, db.ErrAlreadyExists) {
-			err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err)
-			return false, gtserror.NewErrorInternalError(err)
+			// Failed inbox forwarding is not a show-stopper,
+			// and doesn't even necessarily denote a real error.
+			l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err)
 		}
 	}