gtsocial-umbx

commit 40b584c21955341c6f6ae76a172e14ce8c18e490
parent b8e1ab312d5f54d334158e2544eaefba5e54ef5a
Author: Sam Lade <sam@sentynel.com>
Date:   Wed, 15 Feb 2023 19:41:16 +0000

Fix 410 Gone race on account deletes (#1507)


Diffstat:
M
internal/federation/federatingprotocol.go
 | 
10
++++++++++

1 file changed, 10 insertions(+), 0 deletions(-)
diff --git a/internal/federation/federatingprotocol.go b/internal/federation/federatingprotocol.go
@@ -209,6 +209,16 @@ func (f *federator) AuthenticatePostInbox(ctx context.Context, w http.ResponseWr
 		transport.WithFastfail(ctx), username, publicKeyOwnerURI, false,
 	)
 	if err != nil {
+		if errors.Is(err, transport.ErrGone) {
+			// This is the same case as the http.StatusGone check above.
+			// It can happen here and not there because there's a race
+			// where the sending server starts sending account deletion
+			// notifications out, we start processing, the request above
+			// succeeds, and *then* the profile is removed and starts
+			// returning 410 Gone, at which point _this_ request fails.
+			w.WriteHeader(http.StatusAccepted)
+			return ctx, false, nil
+		}
 		return nil, false, fmt.Errorf("couldn't get requesting account %s: %s", publicKeyOwnerURI, err)
 	}