nightmaremail

commit 2a469cc632ac74bc2cb915e6f8cd0ccc330d88f6
parent 691e99b6dff1aef5dfe8e5ab5e73da8bc3145bc7
Author: Amitai Schleier <schmonz-web-git@schmonz.com>
Date:   Mon, 26 Aug 2019 22:16:57 -0400

qmail-popup: leave kid's stderr alone for logging.

Diffstat:
M
CHANGES
 | 
1
+
M
qmail-popup.8
 | 
5
++---
M
qmail-popup.c
 | 
1
-

3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,4 @@
+20200514 code: changed qmail-popup interface (leave kid's fd 2 alone).
 20200511 code: remove tryshsgr.c and use uid_t, gid_t types.
 20200511 add first unittest, run with "make test"
 20191227 fixed possible overflow in alloc() with allocations close to 4GiB
diff --git a/qmail-popup.8 b/qmail-popup.8
@@ -31,9 +31,8 @@ It reads a username and password from descriptor 0
 in POP's USER-PASS style or APOP style.
 It invokes
 .IR subprogram ,
-with the same descriptors 0 and 1;
-descriptor 2 writing to the network;
-and descriptor 3 reading the username, a 0 byte, the password,
+with the same descriptors 0 and 1,
+and with descriptor 3 reading the username, a 0 byte, the password,
 another 0 byte, 
 an APOP timestamp derived from
 .IR hostname ,
diff --git a/qmail-popup.c b/qmail-popup.c
@@ -88,7 +88,6 @@ char *pass;
   int wstat;
   int pi[2];
  
-  if (fd_copy(2,1) == -1) die_pipe();
   close(3);
   if (pipe(pi) == -1) die_pipe();
   if (pi[0] != 3) die_pipe();